Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure_Engine: Add engine methods for foundation classes #3138

Merged
merged 35 commits into from
Sep 8, 2023
Merged

Structure_Engine: Add engine methods for foundation classes #3138

merged 35 commits into from
Sep 8, 2023

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Aug 14, 2023 •
edited
Loading

NOTE: Depends on

BHoM/BHoM#1545

Issues addressed by this PR

Closes #3137

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM/Structure_oM/%231543-FoundationClasses/Foundation%20classes%20and%20associated%20methods.gh?csf=1&web=1&e=Q17tVv

Changelog

  • Added necessary methods for PadFoundation and PileFoundation to work with IElement2D and IElementM respectively;
  • Added Create methods for PadFoundation, PileFoundation and PileGroup
  • Updated IsNull methods to include new foundation objects;
  • Added GrahamScan method to determine the perimeter of a List<Point> which is used in the Create methods for a PileFoundation.

Additional comments

@peterjamesnugent peterjamesnugent self-assigned this Aug 14, 2023
@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Aug 15, 2023
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@peterjamesnugent peterjamesnugent marked this pull request as ready for review August 15, 2023 18:09
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 15, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 124 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Aug 16, 2023

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Aug 16, 2023

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

pawelbaran
pawelbaran reviewed Aug 20, 2023
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍 but same as in the oM, I left quite a few comments - hopefully they will be more help than distraction.

Geometry_Engine/Compute/GrahamScan.cs Outdated Show resolved Hide resolved
Geometry_Engine/Compute/GrahamScan.cs Outdated Show resolved Hide resolved
Geometry_Engine/Compute/GrahamScan.cs Outdated Show resolved Hide resolved
Geometry_Engine/Compute/GrahamScan.cs Outdated Show resolved Hide resolved
Geometry_Engine/Compute/GrahamScan.cs Outdated Show resolved Hide resolved
Structure_Engine/Create/Elements/PadFoundation.cs Outdated Show resolved Hide resolved
Structure_Engine/Create/Elements/PadFoundation.cs Outdated Show resolved Hide resolved
Structure_Engine/Create/Elements/PileFoundaton.cs Outdated Show resolved Hide resolved
Structure_Engine/Modify/Transform.cs Show resolved Hide resolved
Structure_Engine/Query/OutlineElements1D.cs Outdated Show resolved Hide resolved
@pawelbaran
Copy link
Member

Btw, you may need a dedicated Geometry method for PileFoundation - easy to verify by checking if the objects have preview in GH

@peterjamesnugent peterjamesnugent removed the request for review from epignatelli September 8, 2023 08:36
@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check unit-tests
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check unit-tests
  • check copyright-compliance
  • check dataset-compliance

There are 9 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member Author

@BHoMBot check copyright-compliance
@BHoMBot check unit-tests
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check unit-tests
  • check dataset-compliance

There are 8 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

FraserGreenroyd
FraserGreenroyd approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @Chrisshort92 review - following commits by @peterjamesnugent have been compliance updates.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Sep 8, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 8ee78ef into develop Sep 8, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Structure_oM-#1543-AddFoundationClasses branch September 8, 2023 16:04
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
Merged
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Merged
@KalleEdstroem KalleEdstroem mentioned this pull request Jul 12, 2024
Closed
This was referenced Aug 29, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbaran pawelbaran pawelbaran left review comments

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@Chrisshort92 Chrisshort92 Chrisshort92 left review comments

@Martian42 Martian42 Awaiting requested review from Martian42

@adecler adecler Awaiting requested review from adecler adecler is a code owner

Assignees

@peterjamesnugent peterjamesnugent

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structure_oM: Add associated Engine methods for Foundation classes
5 participants
@peterjamesnugent @pawelbaran @FraserGreenroyd @Chrisshort92 @Maria1129